Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove service trigger in create #27

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Conversation

yoojinko
Copy link
Collaborator

app.create() 시에 service trigger는 세팅하지 않도록 변경하였습니다.
deposit url 은 serviceUrl/deposit 으로 고정하도록 변경하였습니다.
+
default set function들은 app에서만 사용되어 constant가 아니라 module 안 private method 로 이동하였습니다.

Copy link
Collaborator

@akastercomcom akastercomcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@yoojinko
Copy link
Collaborator Author

Thanks for the review!

@yoojinko yoojinko merged commit 7ee3a84 into develop Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants